The discrepancy between students’ preferences and teacher practices for feedback on writing has created difficulty on the side of teachers and confusion on the side of the students. What teachers believe and practice as effective feedback for students may not be the one that students perceive as useful and effective feedback for them. This paper investigates the types of written feedback preferred by the students and the types of feedback provided by the teachers on students’ writing. This study employed a survey design which involved 54 students and 22 teachers using convenience sampling technique. The instrument used in collecting data was a questionnaire in the form of Feedback Scale. The results showed that there were some points of compatibility between students’ preferences and teachers’ practices and some other points were incompatible. The data showed that both students and teachers preferred to have or to give direct feedback but the data also indicated that students liked to have more direct feedback than the teacher could provide. It was also found that the teachers provided more indirect feedback than the students expected to have. The students also preferred unfocused feedback to focused feedback. The findings of the study have crucial implications on writing instruction. There is a need to design writing instructions which accommodate both teachers’ practices and students’ preferences for written feddback. Based on the profile of students’ preference and teachers’ practices, a model of feedback provision in teaching writing is proposed. This model is called preference-based feedback on writing instruction.